Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systematic decompilation bug in _Framework? #37

Open
bolau opened this issue Sep 15, 2016 · 0 comments
Open

Systematic decompilation bug in _Framework? #37

bolau opened this issue Sep 15, 2016 · 0 comments

Comments

@bolau
Copy link

bolau commented Sep 15, 2016

Hi Julien,

first of all - thank you so much for your work on the remote scripts, this is incredible!

I think I've found a systematic bug in the decompilations of _Framework related to Assertions. For example: _Framework/MixerComponent.py:268
The lines below "raise AssertionError" should most probably be unintented one step, otherwise that code is never executed:

if not self._bank_up_button != None:
raise AssertionError
if self.is_enabled(): <<<<<< needs unintent?
new_offset = (value is not 0 or not ...

This seems to occur wherever a raise follows an if.
I guess this is not critical, since nobody will ever execute this. But it's confusing when trying to understand how the stuff works...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant