-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed multiple profile issue #3076
Conversation
🚀 Deployed on https://deploy-preview-3076--glific-frontend.netlify.app |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3076 +/- ##
==========================================
+ Coverage 85.98% 86.03% +0.04%
==========================================
Files 322 322
Lines 10392 10393 +1
Branches 2216 2216
==========================================
+ Hits 8936 8942 +6
+ Misses 1358 1348 -10
- Partials 98 103 +5 ☔ View full report in Codecov by Sentry. |
Glific Run #5232
Run Properties:
|
Project |
Glific
|
Branch Review |
fix/multiple-profiles
|
Run status |
Passed #5232
|
Run duration | 24m 29s |
Commit |
3115a57d41 ℹ️: Merge f481aade18a814409e56e1560c16681e02a6ade1 into 39339eff7cb15d816a55f4e2160c...
|
Committer | Akansha Sakhre |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
169
|
View all changes introduced in this branch ↗︎ |
@@ -179,6 +179,12 @@ export const FormLayout = ({ | |||
} | |||
}, [advanceSearch]); | |||
|
|||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's discuss this during stand up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
target issue is #2998 #2911
This PR is dependent on backend PR