Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make actor.Stop respect the given exit reason #88

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sbergen
Copy link

@sbergen sbergen commented Nov 28, 2024

Resolves #89

Requires gleam-lang/erlang#65

The actor would stop with Normal before this.

src/gleam/otp/actor.gleam Outdated Show resolved Hide resolved
@sbergen sbergen changed the title Make actor.Stop(process.Abnormal(...)) exit the process with the given reason Make actor.Stop respect the given exit reason Nov 28, 2024
@sbergen
Copy link
Author

sbergen commented Nov 29, 2024

I noticed afterwards, that there's some overlap between this and #86 Sorry for not spotting it earlier. I'll take a closer look at what was done there later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

actor.Stop always exists the process with Normal, instead of the given exit reason
1 participant