Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix devcontainer/Codespaces #378

Closed
wants to merge 10 commits into from
Closed

Fix devcontainer/Codespaces #378

wants to merge 10 commits into from

Conversation

jessehouwing
Copy link
Contributor

Moves to ubuntu-jammy
Fixes #377

@jessehouwing jessehouwing mentioned this pull request Oct 27, 2022
Open
2 tasks
parkerbxyz
parkerbxyz reviewed Oct 31, 2022
View reviewed changes
Copy link
Contributor

@parkerbxyz parkerbxyz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @jessehouwing! After testing your changes, the container creation was still failing for me. I regenerated the files, made a few more tweaks, and it is working for me now. Can you confirm it works for you too?

@parkerbxyz parkerbxyz changed the title Fixes devcontainer/codespaces Fix devcontainer/Codespaces Oct 31, 2022
@parkerbxyz
Resolve hadolint DL3008 and DL3009
555cf51 
- Pin versions in apt get install
- Delete the apt-get lists after installing something
@jessehouwing jessehouwing reopened this Nov 1, 2022
@jessehouwing
Copy link
Contributor Author

That broke things. Can't spin up this repo on github codespaces:

2022-11-01 08:20:15.981Z: #12 5.106 Package httpie is not available, but is referred to by another package.
2022-11-01 08:20:15.981Z: #12 5.106 This may mean that the package is missing, has been obsoleted, or
2022-11-01 08:20:15.981Z: #12 5.106 is only available from another source
2022-11-01 08:20:15.981Z: #12 5.106 
2022-11-01 08:20:15.981Z: #12 5.109 E: Version '3.2.1' for 'httpie' was not found

@parkerbxyz
Copy link
Contributor

Looks like 555cf51 broke it by specifying the HTTPie version to appease the linter. Should be fixed now. Can you confirm?

@jessehouwing
Copy link
Contributor Author

Yeah, no version fixes things.

@parkerbxyz
Copy link
Contributor

Commit githubtraining/training-manual@1249f63 should have fixed the problem without removing the HTTPie version. Did you try it before removing the version?

@jessehouwing
Copy link
Contributor Author

I did, computer still said no.

@dzeyelid
Copy link
Contributor

Hello, Thank you for updating codespaces environment. I could update my devcontainer environment to Ubuntu jammy with these updates. I hope this can help you.

@jessehouwing
Copy link
Contributor Author

Rebuilt the codespace from scratch by deleting it, works now!

@parkerbxyz parkerbxyz mentioned this pull request May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parkerbxyz parkerbxyz parkerbxyz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Codespace creation fails
3 participants
@jessehouwing @parkerbxyz @dzeyelid