Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

PR with TA, TC, TF, or DS ID always fails #235

Open
forevergenin opened this issue Feb 10, 2021 · 4 comments
Open

PR with TA, TC, TF, or DS ID always fails #235

forevergenin opened this issue Feb 10, 2021 · 4 comments
Labels
bug Something isn't working O: backlog 🤖 Exempt from stale bot

Comments

@forevergenin
Copy link

Bug Description

When a PR is created with taskid in it's title/description/commit message it always fails.
In my use case task TA0000001 is a valid task with valid state (Defined).

To Reproduce

Steps to reproduce the behavior:

  1. Create a PR with a valid taskir TA??????? in its title.
  2. Confirm in rally the TA??????? is in defined state
  3. Rally check fails for the PR

Expected behavior
Rally check should pass if it's a valid taskid with valid state (Ready/Defined/In-Profress)

Screenshots
Screenshot 2021-02-10 at 2 20 22 PM

@forevergenin forevergenin added the bug Something isn't working label Feb 10, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@zkoppert zkoppert added O: backlog 🤖 Exempt from stale bot and removed O: stale 🤖 labels Mar 15, 2021
@zkoppert
Copy link
Member

I have been able to reproduce this functionality. I'm going to shift to diving into the code to see if I can find why User stories work but not tasks.

@zkoppert zkoppert self-assigned this Mar 23, 2021
@zkoppert zkoppert changed the title PR with TASK Id always fails PR with TASK or TESTCASE ID always fails Mar 23, 2021
@zkoppert zkoppert changed the title PR with TASK or TESTCASE ID always fails PR with TA, TC, or DS ID always fails Mar 24, 2021
@zkoppert zkoppert changed the title PR with TA, TC, or DS ID always fails PR with TA, TC, TF, or DS ID always fails Mar 24, 2021
@zkoppert
Copy link
Member

Also confirmed via app testing that TC, TF, and DS are not working either.

US, DE types are confirmed as functional

@zkoppert
Copy link
Member

I noticed that TF is not listed any of the following lists

rally/lib/RallyValidate.js

Lines 816 to 826 in fe9c7d5

parseArtifact (artifactName) {
const artifact = {}
const typeMapping = {
D: 'defect',
DE: 'defect',
DS: 'defectsuite',
TA: 'task',
TC: 'testcase',
S: 'hierarchicalrequirement',
US: 'hierarchicalrequirement'
}

rally/lib/RallyValidate.js

Lines 733 to 740 in fe9c7d5

const prefixMapping = {
defect: ['D', 'DE'],
defectsuite: ['DS'],
task: ['TA'],
testcase: 'TC',
hierarchicalrequirement: ['S', 'US'],
userstory: ['S', 'US'],
story: ['S', 'US']

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working O: backlog 🤖 Exempt from stale bot
Projects
None yet
Development

No branches or pull requests

2 participants