Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Support for validation of PR body OR title OR commits #203

Open
ineffyble opened this issue Dec 4, 2020 · 3 comments
Open

Support for validation of PR body OR title OR commits #203

ineffyble opened this issue Dec 4, 2020 · 3 comments
Labels
enhancement New feature or request O: backlog 🤖 Exempt from stale bot

Comments

@ineffyble
Copy link
Contributor

Is your feature request related to a problem? Please describe.
As a team leader, I want to encourage my team to link their work to Rally artifacts, without being prescriptive in how they do this.

Describe the solution you'd like
There should be an option to validate that a Rally artifact is present in one of the supported fields.

@ineffyble ineffyble added the enhancement New feature or request label Dec 4, 2020
@github-actions
Copy link

github-actions bot commented Jan 4, 2021

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

@ineffyble
Copy link
Contributor Author

This should stay open.

@primetheus primetheus added the O: backlog 🤖 Exempt from stale bot label Jan 9, 2021
@JoshuaTheMiller
Copy link
Contributor

JoshuaTheMiller commented Jan 27, 2022

How about making this work similar to Flag Enums in C#. Users could set a single value, locationsToCheck and pass an array of the locations they would want this bot to check. This could also help satisfy #121 if it was deemed something this Probot would like to support.

An additional option could be added to change how many locations are required (to continue the existing and-ish behavior): minimumLocations (the name could be made better...).

Example

# .github/rally.yml
locationsToCheck:
- prTitle
- prBody
# - commit
# - branch

minimumLocations: 1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request O: backlog 🤖 Exempt from stale bot
Projects
None yet
Development

No branches or pull requests

3 participants