-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial implementation #1
Conversation
WORKDIR /app | ||
|
||
RUN mkdir /app/bin | ||
RUN mkdir /app/public |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I wanted to persist the uploaded files between restarts, would i have to mount a volume here? maybe a VOLUME
directive would be a good idea here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@boudra you should be able to do it anyway when you start the container right?
but I didn't set it as our standard way to do it just because we don't have a way to persist the full state of the system including the blockchain state until anvil doesn't dump events foundry-rs/foundry#5906
Can you elaborate on the go choice here? Are we planning on using the ipfs go libs more than the hash type? There was probably a discussion that I wasn't part of when i was out sick. |
@vacekj this is just the local service I use in development and since I notice everyone is using the real pinata service for development I decided to share it. I don't think we need to add features, it's just a
the only sub packages included are |
@gravityblast re: first part - sounds good to me. re: second part - I misread the code - nothing I would like to add personally, @bard asked about "forking the chain"-like funcitonality with real pinata, but personally I don't have a need for that. |
I was referring to IPFS in general, i.e. wondering if at any point we're going to need IPFS resources outside of what is uploaded as part of a test setup, as it might be the case when trying to reproduce locally a production bug. |
This is a good point, there's also the indexer to consider, how does the forking work with We could have the indexer start from the forked block, but there are other cases we might not consider so it would make sense to have this service behave the same as the node and "fork" Pinata. Another option could be just having the development environment not fork anything, so a pure offline set up. |
I imagine the fork scenario with a different config.
I don't think we will need a mixed environment but I'm happy to talk about it if you guys have any scenario in mind.
yes it will need to get logs from the local chain, and files from past rounds/projects would be available in pinata.
yes this is the current idea, but we can continue thinking about the forking scenario for specific tests we want to reproduce, but not really for development |
a simple implementation of the pinata API that we can use in our local environment to avoid using the real API and being able to use it offline.
It's implemented in to have it simple and with just a couple dependencies.
Also, I don't think we will need to develop on top of it but it's just to have a service running from docker compose in our grants stack local dev env.
check the readme file for more info.