Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Karma GAP SDK integration #3675

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

veganbeef
Copy link
Contributor

Fixes: PAR-434

Description

This PR adds a new package to host an expanded version of the useGap hook from the grants-explorer package, with the intention of using the karma-gap-sdk package to integrate directly with Karma GAP.

Note: There is a dependency mismatch between karma-gap-sdk, which requires ethers v6, and the rest of the grants-stack packages, which require ethers v5. It might be best to prove out this functionality in a standalone app.

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@veganbeef veganbeef requested review from a team as code owners October 7, 2024 19:21
Copy link

linear bot commented Oct 7, 2024

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ❌ Failed (Inspect) Oct 7, 2024 7:22pm
builder-staging ❌ Failed (Inspect) Oct 7, 2024 7:22pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 7:22pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 7:22pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 7:22pm
manager-staging ❌ Failed (Inspect) Oct 7, 2024 7:22pm

@thelostone-mc
Copy link
Member

Closing this PR as the POC is complete. Will keep branch alive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants