From 2d33e330e12ae198b2e864f0d4d6a21fbe99fb58 Mon Sep 17 00:00:00 2001
From: jackkray <eugen@kapuafrica.com>
Date: Wed, 24 Jul 2024 16:15:49 +0200
Subject: [PATCH] fix(capture-sdk): Remove white spaces on error screen PM-66

---
 .../layout-sw600dp-land/gc_fragment_error.xml | 22 +++++++++----------
 .../res/layout-sw600dp/gc_fragment_error.xml  | 16 +++++++-------
 .../main/res/values-sw600dp-land/dimens.xml   |  1 +
 .../src/main/res/values-sw600dp/dimens.xml    |  1 +
 .../sdk/src/main/res/values/dimens.xml        |  1 +
 5 files changed, 22 insertions(+), 19 deletions(-)

diff --git a/capture-sdk/sdk/src/main/res/layout-sw600dp-land/gc_fragment_error.xml b/capture-sdk/sdk/src/main/res/layout-sw600dp-land/gc_fragment_error.xml
index ef84dd5f63..b7aca5b318 100644
--- a/capture-sdk/sdk/src/main/res/layout-sw600dp-land/gc_fragment_error.xml
+++ b/capture-sdk/sdk/src/main/res/layout-sw600dp-land/gc_fragment_error.xml
@@ -24,7 +24,7 @@
         android:alpha="0.15"
         android:background="@color/gc_error_01"/>
 
-    <RelativeLayout
+    <LinearLayout
         android:id="@+id/gc_error_header_layout"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
@@ -32,15 +32,16 @@
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         android:layout_alignParentTop="true"
+        android:orientation="horizontal"
         android:layout_marginTop="@dimen/gc_large"
-        android:minHeight="@dimen/gc_large_64"
-        android:paddingStart="@dimen/gc_large_24"
-        android:paddingEnd="@dimen/gc_large_24">
+        android:minHeight="@dimen/gc_large_42"
+        android:paddingStart="@dimen/gc_large_48"
+        android:paddingEnd="@dimen/gc_large_48">
 
         <ImageView
             android:id="@+id/gc_error_header_icon"
             android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
+            android:layout_height="match_parent"
             android:layout_centerVertical="true"
             android:layout_toStartOf="@id/gc_error_header"
             android:layout_marginEnd="@dimen/gc_large_24"
@@ -51,22 +52,21 @@
             android:id="@+id/gc_error_header"
             style="@style/GiniCaptureTheme.Typography.Body2"
             android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_centerInParent="true"
+            android:layout_height="match_parent"
             android:gravity="center"
             android:text="@string/gc_error_upload_title" />
-    </RelativeLayout>
+    </LinearLayout>
 
     <TextView
         android:id="@+id/gc_error_textview"
         style="@style/GiniCaptureTheme.Typography.Body2"
-        android:layout_width="@dimen/gc_tablet_width"
+        android:layout_width="0dp"
         android:layout_height="0dp"
         android:layout_marginTop="@dimen/gc_large_24"
         android:textColor="@color/gc_dark_06"
         android:text="@string/gc_error_upload_text"
-        android:layout_marginStart="@dimen/gc_large_24"
-        android:layout_marginEnd="@dimen/gc_large_24"
+        android:layout_marginStart="@dimen/gc_large_48"
+        android:layout_marginEnd="@dimen/gc_large_48"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintBottom_toTopOf="@id/gc_error_button_container"
diff --git a/capture-sdk/sdk/src/main/res/layout-sw600dp/gc_fragment_error.xml b/capture-sdk/sdk/src/main/res/layout-sw600dp/gc_fragment_error.xml
index 566c89b681..b7aca5b318 100644
--- a/capture-sdk/sdk/src/main/res/layout-sw600dp/gc_fragment_error.xml
+++ b/capture-sdk/sdk/src/main/res/layout-sw600dp/gc_fragment_error.xml
@@ -24,7 +24,7 @@
         android:alpha="0.15"
         android:background="@color/gc_error_01"/>
 
-    <RelativeLayout
+    <LinearLayout
         android:id="@+id/gc_error_header_layout"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
@@ -32,15 +32,16 @@
         app:layout_constraintStart_toStartOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         android:layout_alignParentTop="true"
+        android:orientation="horizontal"
         android:layout_marginTop="@dimen/gc_large"
-        android:minHeight="@dimen/gc_large_64"
-        android:paddingStart="@dimen/gc_large_24"
-        android:paddingEnd="@dimen/gc_large_24">
+        android:minHeight="@dimen/gc_large_42"
+        android:paddingStart="@dimen/gc_large_48"
+        android:paddingEnd="@dimen/gc_large_48">
 
         <ImageView
             android:id="@+id/gc_error_header_icon"
             android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
+            android:layout_height="match_parent"
             android:layout_centerVertical="true"
             android:layout_toStartOf="@id/gc_error_header"
             android:layout_marginEnd="@dimen/gc_large_24"
@@ -51,11 +52,10 @@
             android:id="@+id/gc_error_header"
             style="@style/GiniCaptureTheme.Typography.Body2"
             android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_centerInParent="true"
+            android:layout_height="match_parent"
             android:gravity="center"
             android:text="@string/gc_error_upload_title" />
-    </RelativeLayout>
+    </LinearLayout>
 
     <TextView
         android:id="@+id/gc_error_textview"
diff --git a/capture-sdk/sdk/src/main/res/values-sw600dp-land/dimens.xml b/capture-sdk/sdk/src/main/res/values-sw600dp-land/dimens.xml
index 2642c781c0..b3b311659e 100644
--- a/capture-sdk/sdk/src/main/res/values-sw600dp-land/dimens.xml
+++ b/capture-sdk/sdk/src/main/res/values-sw600dp-land/dimens.xml
@@ -7,6 +7,7 @@
     <dimen name="gc_large_20">20dp</dimen>
     <dimen name="gc_large_24">24dp</dimen>
     <dimen name="gc_large_32">32dp</dimen>
+    <dimen name="gc_large_42">52dp</dimen>
     <dimen name="gc_large_48">64dp</dimen>
     <dimen name="gc_large_64">80dp</dimen>
     <dimen name="gc_large_80">96dp</dimen>
diff --git a/capture-sdk/sdk/src/main/res/values-sw600dp/dimens.xml b/capture-sdk/sdk/src/main/res/values-sw600dp/dimens.xml
index fc0073283a..8503147102 100644
--- a/capture-sdk/sdk/src/main/res/values-sw600dp/dimens.xml
+++ b/capture-sdk/sdk/src/main/res/values-sw600dp/dimens.xml
@@ -7,6 +7,7 @@
     <dimen name="gc_large_20">20dp</dimen>
     <dimen name="gc_large_24">24dp</dimen>
     <dimen name="gc_large_32">32dp</dimen>
+    <dimen name="gc_large_42">52dp</dimen>
     <dimen name="gc_large_48">64dp</dimen>
     <dimen name="gc_large_64">80dp</dimen>
     <dimen name="gc_large_80">96dp</dimen>
diff --git a/capture-sdk/sdk/src/main/res/values/dimens.xml b/capture-sdk/sdk/src/main/res/values/dimens.xml
index 1e3350c927..115372ddcf 100644
--- a/capture-sdk/sdk/src/main/res/values/dimens.xml
+++ b/capture-sdk/sdk/src/main/res/values/dimens.xml
@@ -6,6 +6,7 @@
     <dimen name="gc_large_20">20dp</dimen>
     <dimen name="gc_large_24">24dp</dimen>
     <dimen name="gc_large_32">32dp</dimen>
+    <dimen name="gc_large_42">42dp</dimen>
     <dimen name="gc_large_48">48dp</dimen>
     <dimen name="gc_large_64">64dp</dimen>
     <dimen name="gc_large_80">80dp</dimen>