First commit for Espresso test #462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danicretu
reviewed
Jul 3, 2024
There was a problem hiding this comment.
Great work Syeda, thank you! I left a couple of comments, nothing big, mostly related to renaming and removing unused code.
Also, please take a look at the git commit template we use in the repository and use the agreed convention when committing:
ci(ui-automation): Add Espresso for GiniBankSDKExample
PM-89
...ample-app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/HelpScreen.kt
Outdated
Show resolved
Hide resolved
...le-app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/CaptureScreen.kt
Outdated
Show resolved
Hide resolved
...ample-app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/HelpScreen.kt
Outdated
Show resolved
Hide resolved
...ample-app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/HelpScreen.kt
Outdated
Show resolved
Hide resolved
...ample-app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/MainScreen.kt
Outdated
Show resolved
Hide resolved
...ample-app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/MainScreen.kt
Outdated
Show resolved
Hide resolved
...ample-app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/MainScreen.kt
Outdated
Show resolved
Hide resolved
...ample-app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/MainScreen.kt
Outdated
Show resolved
Hide resolved
...app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/OnboardingScreen.kt
Outdated
Show resolved
Hide resolved
...p/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/MainActivityTest.kt
Outdated
Show resolved
Hide resolved
|
@danicretu We've discussed the commit style for automation specifically and here is the reference for the structure of commit |
|
Thanks @danicretu for your input. |
danicretu
approved these changes
Jul 5, 2024
a-szotyori
suggested changes
Jul 9, 2024
There was a problem hiding this comment.
Great work, @SyedaGini! I still see some improvement potential though 🙈
Thank you for using the POM pattern! For the tests I would advise to apply these tips:
- Explicitly state in the test method name what is tested. It's ok to have long test method names.
- A test should generally assert one thing only at the end of the test. There can and will be exceptions, but as a rule of thumb try to assert only one thing at the end of the test.
- Tests should be independent so that we can run one specific test without having to run x nr of other tests before it. Imagine we want to fix
test30_...and then we would need to run the previous 29 tests each time we want to see if test 30 works or not...
...ample-app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/HelpScreen.kt
Outdated
Show resolved
Hide resolved
...ample-app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/HelpScreen.kt
Outdated
Show resolved
Hide resolved
...ample-app/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/screens/HelpScreen.kt
Outdated
Show resolved
Hide resolved
...p/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/MainActivityTest.kt
Outdated
Show resolved
Hide resolved
...p/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/MainActivityTest.kt
Outdated
Show resolved
Hide resolved
...p/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/MainActivityTest.kt
Outdated
Show resolved
Hide resolved
...p/src/androidTest/java/net/gini/android/bank/sdk/exampleapp/ui/testcases/MainActivityTest.kt
Outdated
Show resolved
Hide resolved
|
@a-szotyori the requested changes are incorporated, thank you! |
a-szotyori
approved these changes
Jul 16, 2024
SyedaGini
force-pushed
the
test-automation
branch
from
8013abc to
88dd996
Compare
…indow` The emulator won't start without `-no-window` on GitHub Action runners. This reverts commit 2aea8c9. PM-89
|
PM-26
Added automation for No Result Screen
Added automation for Digital Invoice Screen
Added automation for File Import Error Screen
…ice) Added automation for Edit Button on Digital Invoice Screen.
Added automation for Error Screens
Pp 860 automation test files
PM-122
ci: Add scrollTo option
Fix failing test cases
…ageIsCaptured PM-122
Fix failing test cases
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI automation Test cases using Espresso