fix(capture-sdk): Discard QR code detections after the `PaymentQRCode…

…Reader` is released PIA-4414
gini · Aug 30, 2023 · ba8a2ea · ba8a2ea
1 parent b5c0709
commit ba8a2ea
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/capture-sdk/sdk/src/main/java/net/gini/android/capture/camera/CameraFragmentImpl.java b/capture-sdk/sdk/src/main/java/net/gini/android/capture/camera/CameraFragmentImpl.java
@@ -437,12 +437,6 @@ private void initFlashButton() {
      * @suppress
      */
     public void onResume() {
-        if (mPaymentQRCodePopup != null) {
-            mPaymentQRCodePopup.hide();
-        }
-        if (mUnsupportedQRCodePopup != null) {
-            mUnsupportedQRCodePopup.hide();
-        }
         initMultiPageDocument();
     }
 
@@ -584,6 +578,12 @@ void onSaveInstanceState(@NonNull final Bundle outState) {
 
     void onStop() {
         closeCamera();
+        if (mPaymentQRCodePopup != null) {
+            mPaymentQRCodePopup.hide();
+        }
+        if (mUnsupportedQRCodePopup != null) {
+            mUnsupportedQRCodePopup.hide();
+        }
     }
 
     void onDestroy() {

diff --git a/...e-sdk/sdk/src/main/java/net/gini/android/capture/internal/qrcode/PaymentQRCodeReader.java b/...e-sdk/sdk/src/main/java/net/gini/android/capture/internal/qrcode/PaymentQRCodeReader.java
@@ -43,6 +43,7 @@ public void onNonPaymentQRCodeDetected(@NonNull final String qrCodeContent) {
         public void onQRCodeReaderFail() {
         }
     };
+    private boolean isReleased = false;
 
     /**
      * Create a new instance which uses the provided {@link QRCodeDetectorTask} to do QRCode
@@ -66,6 +67,9 @@ private PaymentQRCodeReader(
         mDetector.setListener(new QRCodeDetector.Listener() {
             @Override
             public void onQRCodesDetected(@NonNull final List<String> qrCodes) {
+                if (isReleased) {
+                    return;
+                }
                 for (final String qrCodeContent : qrCodes) {
                     try {
                         final PaymentQRCodeData paymentData = mParser.parse(qrCodeContent);
@@ -119,6 +123,7 @@ public void readFromByteArray(@NonNull final byte[] image, @NonNull final Size i
      * Release all resources. Detection not possible after this has been called.
      */
     public void release() {
+        isReleased = true;
         mDetector.release();
     }