refactor(): Remove onFinishedWithCancellation() function from listene…

…r interfaces This is covered by the `CaptureSDKResult` and `CaptureResult` in `Cancel` state. - remove onFinishedWithCancellation() from GiniCaptureFragmentListener - remove onFinishedWithCancellation() from CaptureFlowFragmentListener BSDK-258
gini · Jan 19, 2024 · 5221996 · 5221996
1 parent e2fa698
commit 5221996
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 13 deletions.
diff --git a/...le-app/src/main/java/net/gini/android/bank/sdk/exampleapp/ui/ClientGiniCaptureFragment.kt b/...le-app/src/main/java/net/gini/android/bank/sdk/exampleapp/ui/ClientGiniCaptureFragment.kt
@@ -176,10 +176,6 @@ class ClientGiniCaptureFragment :
     }
 
 
-    override fun onFinishedWithCancellation() {
-        requireActivity().finish()
-    }
-
 
 }
 

diff --git a/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/CaptureFlowFragment.kt b/bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/CaptureFlowFragment.kt
@@ -114,10 +114,6 @@ class CaptureFlowFragment(private val analysisIntent: Intent? = null) :
         }
     }
 
-    override fun onFinishedWithCancellation() {
-        captureFlowFragmentListener.onFinishedWithCancellation()
-    }
-
     override fun onPayInvoice(
         specificExtractions: Map<String, GiniCaptureSpecificExtraction>,
         compoundExtractions: Map<String, GiniCaptureCompoundExtraction>
@@ -145,8 +141,6 @@ class CaptureFlowFragment(private val analysisIntent: Intent? = null) :
 interface CaptureFlowFragmentListener {
     fun onFinishedWithResult(result: CaptureResult)
 
-    fun onFinishedWithCancellation()
-
     fun onCheckImportedDocument(
         document: Document,
         callback: CameraFragmentListener.DocumentCheckResultCallback

diff --git a/capture-sdk/sdk/src/main/java/net/gini/android/capture/GiniCaptureFragment.kt b/capture-sdk/sdk/src/main/java/net/gini/android/capture/GiniCaptureFragment.kt
@@ -212,7 +212,7 @@ class GiniCaptureFragment(private val analysisIntent: Intent? = null) :
     }
 
     override fun onDefaultPDFAppAlertDialogCancelled() {
-        giniCaptureFragmentListener.onFinishedWithCancellation()
+        giniCaptureFragmentListener.onFinishedWithResult(CaptureSDKResult.Cancel)
     }
 
     override fun onExtractionsAvailable(extractions: MutableMap<String, GiniCaptureSpecificExtraction>) {
@@ -286,8 +286,6 @@ class CaptureFragmentFactory(
 interface GiniCaptureFragmentListener {
     fun onFinishedWithResult(result: CaptureSDKResult)
 
-    fun onFinishedWithCancellation()
-
     fun onCheckImportedDocument(
         document: Document,
         callback: CameraFragmentListener.DocumentCheckResultCallback
-Original file line number
+Diff line change
@@ Expand Up / @@ -176,10 +176,6 @@ class ClientGiniCaptureFragment : @@
         }
-        override fun onFinishedWithCancellation() {
-            requireActivity().finish()
-        }
     }
@@ Expand Down @@