refactor(capture-sdk): Fix tests related to help screens

BSDK-258
gini · Jan 12, 2024 · 34814cd · 34814cd
1 parent 21f7c42
commit 34814cd
Show file tree

Hide file tree

Showing 3 changed files with 53 additions and 30 deletions.
diff --git a/capture-sdk/sdk/src/test/java/net/gini/android/capture/camera/CameraActivityTest.kt b/capture-sdk/sdk/src/test/java/net/gini/android/capture/camera/CameraActivityTest.kt
@@ -47,25 +47,4 @@ class CameraActivityTest {
         }
     }
 
-    @Test
-    fun `triggers Help event when help was started`() {
-        // Given
-        val eventTracker = spy<EventTracker>()
-        GiniCapture.Builder().setEventTracker(eventTracker).build()
-
-        ActivityScenario.launch(CameraActivity::class.java).use { scenario ->
-            scenario.moveToState(Lifecycle.State.STARTED)
-
-            // When
-            scenario.onActivity { activity ->
-                val menuItem = mock<MenuItem>()
-                whenever(menuItem.itemId).thenReturn(R.id.gc_action_show_onboarding)
-                activity.onOptionsItemSelected(menuItem)
-
-                // Then
-                verify(eventTracker).onCameraScreenEvent(Event(CameraScreenEvent.HELP))
-            }
-        }
-    }
-
 }
diff --git a/capture-sdk/sdk/src/test/java/net/gini/android/capture/camera/CameraFragmentImplTest.kt b/capture-sdk/sdk/src/test/java/net/gini/android/capture/camera/CameraFragmentImplTest.kt
@@ -1,20 +1,21 @@
 package net.gini.android.capture.camera
 
 import android.app.Activity
+import androidx.fragment.app.Fragment
+import androidx.fragment.app.FragmentManager
+import androidx.fragment.app.FragmentTransaction
 import androidx.test.ext.junit.runners.AndroidJUnit4
-import androidx.test.platform.app.InstrumentationRegistry
 import com.google.common.truth.Truth
 import com.nhaarman.mockitokotlin2.*
 import jersey.repackaged.jsr166e.CompletableFuture
-import net.gini.android.capture.Amount
 import net.gini.android.capture.GiniCapture
 import net.gini.android.capture.GiniCaptureError
 import net.gini.android.capture.GiniCaptureHelper
 import net.gini.android.capture.internal.camera.api.CameraInterface
+import net.gini.android.capture.internal.ui.FragmentImplCallback
 import net.gini.android.capture.tracking.CameraScreenEvent
 import net.gini.android.capture.tracking.Event
 import net.gini.android.capture.tracking.EventTracker
-import org.junit.After
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.mockito.Mockito
@@ -70,4 +71,49 @@ class CameraFragmentImplTest {
         Truth.assertThat(args.firstValue.errorCode)
             .isEqualTo(GiniCaptureError.ErrorCode.MISSING_GINI_CAPTURE_INSTANCE)
     }
+
+    @Test
+    fun `triggers Help event when help was started`() {
+        // Given
+        val eventTracker = spy<EventTracker>()
+        GiniCapture.Builder().setEventTracker(eventTracker).build()
+
+        // Stub the fragment transaction related calls
+        val fragmentCallbackStub = mock<FragmentImplCallback>()
+        whenever(fragmentCallbackStub.childFragmentManager).thenReturn(object: FragmentManager() {
+            override fun beginTransaction(): FragmentTransaction {
+                return object: FragmentTransaction() {
+                    override fun add(containerViewId: Int, fragment: Fragment, tag: String?): FragmentTransaction {
+                        return this;
+                    }
+
+                    override fun addToBackStack(name: String?): FragmentTransaction {
+                        return this
+                    }
+
+                    override fun commit(): Int {
+                        return 0
+                    }
+
+                    override fun commitAllowingStateLoss(): Int {
+                        return 0
+                    }
+
+                    override fun commitNow() {
+                    }
+
+                    override fun commitNowAllowingStateLoss() {
+                    }
+                }
+            }
+        })
+
+        val fragmentImpl = CameraFragmentImpl(fragmentCallbackStub)
+
+        // When
+        fragmentImpl.startHelpActivity()
+
+        // Then
+        verify(eventTracker).onCameraScreenEvent(Event(CameraScreenEvent.HELP))
+    }
 }
diff --git a/.../android/capture/help/HelpActivityTest.kt → .../android/capture/help/HelpFragmentTest.kt b/.../android/capture/help/HelpActivityTest.kt → .../android/capture/help/HelpFragmentTest.kt
@@ -1,7 +1,7 @@
 package net.gini.android.capture.help
 
 import android.content.Intent
-import androidx.test.core.app.launchActivity
+import androidx.fragment.app.testing.launchFragmentInContainer
 import androidx.test.espresso.Espresso.onView
 import androidx.test.espresso.action.ViewActions.click
 import androidx.test.espresso.assertion.ViewAssertions.matches
@@ -13,15 +13,13 @@ import androidx.test.espresso.matcher.ViewMatchers.isDisplayed
 import androidx.test.ext.junit.runners.AndroidJUnit4
 import androidx.test.platform.app.InstrumentationRegistry
 import com.nhaarman.mockitokotlin2.mock
-import net.gini.android.capture.Amount
 import net.gini.android.capture.GiniCapture
 import net.gini.android.capture.R
-import org.junit.After
 import org.junit.Test
 import org.junit.runner.RunWith
 
 @RunWith(AndroidJUnit4::class)
-class HelpActivityTest {
+class HelpFragmentTest {
 
     @Test
     fun `shows custom help items`() {
@@ -44,7 +42,7 @@ class HelpActivityTest {
             .build()
 
         // When
-        launchActivity<HelpActivity>().use {
+        launchFragmentInContainer<HelpFragment>(themeResId = R.style.GiniCaptureTheme).use {
             // Then
             onView(ViewMatchers.withText(customTitle)).check(matches(isDisplayed()))
         }
@@ -73,7 +71,7 @@ class HelpActivityTest {
         // When
         Intents.init()
 
-        launchActivity<HelpActivity>().use {
+        launchFragmentInContainer<HelpFragment>(themeResId = R.style.GiniCaptureTheme).use {
             // Then
             onView(ViewMatchers.withText(customTitle)).perform(click())