Skip to content
This repository has been archived by the owner on Oct 18, 2022. It is now read-only.

More advanced filtering of messages in GelfLoggingFilter #25

Open
madmuffin1 opened this issue Feb 13, 2017 · 1 comment
Open

More advanced filtering of messages in GelfLoggingFilter #25

madmuffin1 opened this issue Feb 13, 2017 · 1 comment

Comments

@madmuffin1
Copy link

Hi there,

we're currently using the GelfLoggingFilter to log access requests. Since our loadbalancers send HTTP pings to a special endpoint, this creates a lot of noise, that we don't need in our logs.

I would love to extend the current GelfLoggingFilter implementation by adding an optional filtering parameter to the GelfLoggingFilter constructor that will be called in the logRequest method, when we have access to both the response and the request and drop such (matching an url and response code 200) access messages.

To make this as extensible as possible, I would suggest the usage of a functional interface that receives all the parameters that the receives the last four parameters that the logRequest method gets.

Would you accept such an addition? If so, I will prepare a MR.

Thanks

@joschi
Copy link
Contributor

joschi commented Apr 3, 2017

@madmuffin1 Sure, we can give it a go. Looking forward to your pull request!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants