-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve GitHub push event posts in Zulip #37
Comments
A test GH Action is added to And it works! Now we just have to fill it with useful content 🙂 |
Maybe this to get the list of changed files: https://github.com/marketplace/actions/changed-files |
And this is how to get the username for the push event: https://github.com/orgs/community/discussions/25196 |
(kvifor skriv eg på engelsk, eigentleg???) Nokre tinget kom til.å tenkja på:
Dermed føreslår eg dette:
Det betyr altså at meldingane i GitHub skulle kunne vera noko i stil med dette oppsettet:
Då vil det koma to meldingar for kvar push, men dei skulle i så fall vera komplementære. Tankar om det? |
No er ein fyrste versjon på plass i |
Eg køyrer ut den versjonen vi har no, og så kan vi arbeida vidare med han etter kvart. Eg trur meldingane vi generer no er nyttige som dei er, sjølv med dei avgresningane som finst. |
Background: the commit messages in Zulip we have now is not very informative, and lack essential information to do light-weight code reviews in the way we used to do when using
svn
. At that time, we received an email for each commit, containing a list of all changed files + a diff for the first 1000 lines or so.Now I stumbled across the following: https://github.com/zulip/github-actions-zulip#readme
Using it we can build an action that sends a message to Zulip that contains exactly what we want. The most wanted content is:
In addition, we want to include what is already now present:
There is an absolute limit of 10 000 bytes in each post. And we don't want to spam our Zulip streams too much.
The text was updated successfully, but these errors were encountered: