Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important note regarding the use of other software #11

Open
Lamparter opened this issue Dec 7, 2024 · 3 comments
Open

Important note regarding the use of other software #11

Lamparter opened this issue Dec 7, 2024 · 3 comments

Comments

@Lamparter
Copy link

Hi there! 🙂

I want to start by acknowledging the effort and enthusiasm you've shown in contributing to the open-source community through your projects. It's always great to see passionate developers engaging in collaborative development!

I recently took a look at the DevWinUI and HandyControls repositories, and I noticed a few areas where some improvements might be necessary to align with open-source best practices and licensing requirements. I wanted to share these observations with the intention of helping all of us maintain the high standards of our community 😁

  • The logo currently used in devwinui closely resembles Microsoft's WinUI logo. As this is a trademarked and automatically copyrighted design, it might be helpful to consider creating a unique logo or obtaining proper permissions from Microsoft to use theirs.

  • It looks like a significant portion of the control implementations may have originated from projects licensed under the MIT License. It’s important to ensure that proper attributions are provided wherever necessary. Including original copyright notices and permission details can clear up usage rights and honour the original developers’ contributions - it doesn't exactly look like the ThirdPartyNotices file in the root directory is anywhere near enough 😅

  • (more about HandyControls) There appear to be instances where code from other repositories, like HandyControl, is being used. Please remember that blatantly copying something (even licensed under MIT license) without attribution and attempting to pass it off as yours (aside from being just wrong) also goes against various morally asserted copyright conventions.

I believe making these changes will not only help avoid potential legal issues but also enhance the credibility and impact of your projects.

Thank you for your understanding and for your contributions to the community. 🚀

@ghost1372
Copy link
Owner

Hi @Lamparter
Thank you for reaching out and for your thoughtful feedback. I greatly appreciate the time and effort you've put into reviewing my projects and providing constructive suggestions.

  • 1.Logo Usage
    You’re absolutely right about the resemblance of the DevWinUI logo to Microsoft's WinUI logo. As a solo developer without access to design resources, I initially used it for simplicity. However, I understand the importance of originality and compliance with trademark policies. I will prioritize creating a unique logo in the future to address this issue.

  • 2.Licensing and Attribution
    I’ve made efforts to include license headers in the files where applicable, but I admit that some instances might have been overlooked. I’ll ensure this is reviewed thoroughly, and proper attributions are added wherever necessary. As for the ThirdPartyNotices , I’ve recently started building that section, and I’ll continue to refine it to make it more comprehensive.

  • 3.Code Usage from HandyControls
    Regarding HandyControls, I’d like to clarify that this project is a fork of the Chinese version of HandyControl. I actively contributed to that repository for years and created this fork with @NaBian's personal permission. Since porting the WPF version to WinUI involved significant changes, I’m curious if it’s still necessary to reference the original repository. I want to ensure I handle this correctly while maintaining proper credit.

Thank you once again for highlighting these areas. Your insights are invaluable, and I’ll work on addressing these points to enhance the quality and compliance of my projects. If you have any further suggestions or resources that might help, please feel free to share.

ghost1372 added a commit that referenced this issue Dec 7, 2024
@Lamparter
Copy link
Author

Thanks for the update bea03a1!

Just wanted to make sure you are aware that the LGPL-3.0 license requires that the library/app where it is consumes must also be licensed under the LGPL or regular GPL.

Also, since a lot of code appears to be from WCT and other providers, I strongly recommend you move the notice in the README to nearer the top. Thank you for your amazing co-operation and I hope to see what you come up with in DevWinUI!

@ghost1372
Copy link
Owner

Thanks for the update bea03a1!

Just wanted to make sure you are aware that the LGPL-3.0 license requires that the library/app where it is consumes must also be licensed under the LGPL or regular GPL.

Also, since a lot of code appears to be from WCT and other providers, I strongly recommend you move the notice in the README to nearer the top. Thank you for your amazing co-operation and I hope to see what you come up with in DevWinUI!

Thank you
I Moved to the top README.
I don't know about that. It seems I need to talk to ikas-mc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants