Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onThese and other functions in EventM are not exported #74

Open
zopa opened this issue Aug 5, 2017 · 0 comments
Open

onThese and other functions in EventM are not exported #74

zopa opened this issue Aug 5, 2017 · 0 comments

Comments

@zopa
Copy link

zopa commented Aug 5, 2017

Several functions in GHCJS.DOM.EventM trigger -Wunused-top-binds. The one that interests me is onThese, which looks useful, but we might as well deal with the rest while I'm at it.

I'm happy to submit a pull request, but I thought I'd check if any of these should be removed rather than exported.

I assume the way to proceed is to submit patches to both jsaddle-dom and this repository, and bump the minor version numbers and constraints?

The functions at issue (from GHCJS/DOM/EventM.hs):

  • onThese
  • eventTargetUnsafe
  • eventTargetUnchecked
  • targetUnsafe
  • targetUnchecked
  • eventCurrentTargetUnsafe
  • eventCurrentTargetUnchecked
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant