Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For a medium size org the caching takes time "gh edu set -o" #6

Open
crguezl opened this issue May 21, 2022 · 4 comments
Open

For a medium size org the caching takes time "gh edu set -o" #6

crguezl opened this issue May 21, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@crguezl
Copy link

crguezl commented May 21, 2022

Took 4 or 5 minutes to finish:

➜  gh-edu git:(main) gh edu set -o ULL-ESIT-PL-2122
Not in cache. Fetching... (Cache will be updated)
Default org set to:  ULL-ESIT-PL-2122

May be we can warn the user to wait or give some estimation of the time is going to take?

@crguezl crguezl added the enhancement New feature or request label May 21, 2022
@crguezl crguezl self-assigned this May 21, 2022
@crguezl
Copy link
Author

crguezl commented May 21, 2022

Another bump just now on this. Tried to change the org (Here cd is an alias of gh edu ...) and took minutes to tell me that I misspelled the org name:

➜  gh-edu git:(main) ✗ gh cd ULL-ESIT-DMSI-2122             
Not in cache. Fetching... (Cache will be updated)
That organization couldn't be found:
ULL-ESIT-DMSI-2122

I know in the long run it is not often that cache has to be updated but is something we have to think.

To cache or not to cache?, that is the question. Whether ’tis nobler in the mind to suffer long delays a few times or ...

@GGCristo
Copy link
Collaborator

This is going to be hard for me to test, but one straightforward solution is to only cache the organization itself, not all of them.

@crguezl
Copy link
Author

crguezl commented May 26, 2022

In the example before, I don't know why it took so long if the organization didn't exists

@GGCristo
Copy link
Collaborator

@crguezl Now set -o will cache only the corresponding organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants