Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh edu install (no args) #3

Open
crguezl opened this issue May 8, 2022 · 3 comments
Open

gh edu install (no args) #3

crguezl opened this issue May 8, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@crguezl
Copy link

crguezl commented May 8, 2022

What do you think about this @GGCristo ?

We will keep of the plugins installed with gh edu install plugin inside the config.json file and then ...

When called without arguments:

gh edu install

should install (or update?) the plugins specified in file config.json.

@GGCristo
Copy link
Collaborator

GGCristo commented May 8, 2022

We have a gh edu update command (Maybe it should be called upgrade instead). We can reuse this command to also update plugins, not only the cache.
Also, gh cli doesn't have this behavior so it could be unintuitive.

@crguezl
Copy link
Author

crguezl commented May 8, 2022

@GGCristo

We have a gh edu update command (Maybe it should be called upgrade instead). We can reuse this command to also update plugins, not only the cache.
Also, gh cli doesn't have this behavior so it could be unintuitive.

Agree. May be gh edu update can be multi-command like:

gh edu update cache    # updates the cache
gh edu update plugins  # updates the plugins
etc.

@crguezl
Copy link
Author

crguezl commented May 8, 2022

Or may be just an option of gh edu update:

program
  .command("update")
  .option("-c, --cache", "Update your cache")
  .option("-p, --plugins", "Update your plugins")
  .option("-a, --all", "Update all")
  .description("Update your configuration")
  .action((options) => {
    update(options);
  })

In any case an user can always update manually, so may be this requirement is not so important and can be delayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants