Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dry_run logic in delete_entity_attributes #29

Open
bknisbac opened this issue Nov 18, 2019 · 1 comment
Open

dry_run logic in delete_entity_attributes #29

bknisbac opened this issue Nov 18, 2019 · 1 comment

Comments

@bknisbac
Copy link
Contributor

Hi,
When running e.g. delete_sample_attributes with dry_run=True, the current logic within delete_entity_attributes dictates that dry_run mode is active only if delete_files=True.

I think it would be more intuitive and prevent accidentally deleting attributes if in such a case a message of the to-be-deleted attributes would be printed without actually deleting them from the data model.

Thank you for dalmatian - it's super useful!
Binyamin

@bknisbac
Copy link
Contributor Author

The case I was alluding to is dry_run=True and delete_files=False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant