Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise more informative error when no outputs are found #39

Open
julianhess opened this issue Mar 16, 2020 · 3 comments
Open

Raise more informative error when no outputs are found #39

julianhess opened this issue Mar 16, 2020 · 3 comments
Labels
bug Something isn't working enhancement New feature or request ux Feature that improve the user experience

Comments

@julianhess
Copy link
Collaborator

Current, if no outputs are found, the only clue is this getting printed to stdout:

Expecting value: line 1 column 1 (char 0)

presumably from delocalizer.py.

We need to make output-related error messages clearer.

@julianhess julianhess added enhancement New feature or request Triage New issues which haven't been assigned to a project and need attention ux Feature that improve the user experience labels Mar 16, 2020
@agraubert agraubert added bug Something isn't working and removed Triage New issues which haven't been assigned to a project and need attention labels Mar 20, 2020
@agraubert
Copy link
Collaborator

This gets printed to a job's stdout and not the terminal, right?

@julianhess
Copy link
Collaborator Author

Correct.

@julianhess
Copy link
Collaborator Author

If the main script exits with nonzero status, we don't want this to be clobbered by a nonzero delocalizer.py exit.

Thus, delocalizer.py should only exit 1 if the script exited 0; otherwise, it should pass through the script's nonzero exit code.

It should write an informative message to stderr. Furthermore, localizer.delocalize() should also pick up on this error and write something to the Canine console output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request ux Feature that improve the user experience
Projects
None yet
Development

No branches or pull requests

2 participants