-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): Add Linux distributions to os context #3443
Merged
iker-barriocanal
merged 5 commits into
getsentry:master
from
supervacuus:feat/support_linux_distribution_in_os_context
Apr 18, 2024
Merged
feat(protocol): Add Linux distributions to os context #3443
iker-barriocanal
merged 5 commits into
getsentry:master
from
supervacuus:feat/support_linux_distribution_in_os_context
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
7 tasks
Dav1dde
approved these changes
Apr 18, 2024
iker-barriocanal
approved these changes
Apr 18, 2024
narsaynorath
pushed a commit
to getsentry/sentry
that referenced
this pull request
May 17, 2024
Users of the Native SDK also want to search for the Linux distributions their events came from: getsentry/sentry-native#943 The corresponding PRs to * develop docs: getsentry/develop#1227 * relay: getsentry/relay#3443 * Native SDK: getsentry/sentry-native#963
cmanallen
pushed a commit
to getsentry/sentry
that referenced
this pull request
May 21, 2024
Users of the Native SDK also want to search for the Linux distributions their events came from: getsentry/sentry-native#943 The corresponding PRs to * develop docs: getsentry/develop#1227 * relay: getsentry/relay#3443 * Native SDK: getsentry/sentry-native#963
JoshuaMoelans
added a commit
that referenced
this pull request
Nov 28, 2024
…4292) (continuation of #3443 ) <!-- Describe your PR here. --> To make these fields searchable, we had to change from a nested to a flattened approach. This is provided in sentry-native ([relevant PR](getsentry/sentry-native#963)). The update is also tracked on the docs side: getsentry/sentry-docs#11936
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users of the Native SDK would love to know and search for the Linux distributions from which their events are coming: getsentry/sentry-native#943
After a basic implementation on the SDK side to parse
/etc/os-release
(getsentry/sentry-native#963), we also need to ensure the data is indexable. This PR is one step towards that goal.There is a "develop" docs PR where we should discuss naming, structure, and content.
Cc: @kahest.