Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): Add Linux distributions to os context #3443

Conversation

supervacuus
Copy link
Contributor

@supervacuus supervacuus commented Apr 17, 2024

Users of the Native SDK would love to know and search for the Linux distributions from which their events are coming: getsentry/sentry-native#943

After a basic implementation on the SDK side to parse /etc/os-release (getsentry/sentry-native#963), we also need to ensure the data is indexable. This PR is one step towards that goal.

There is a "develop" docs PR where we should discuss naming, structure, and content.

Cc: @kahest.

@supervacuus supervacuus requested a review from a team as a code owner April 17, 2024 10:39
@supervacuus
Copy link
Contributor Author

supervacuus commented Apr 17, 2024

I am not sure how this change affects test_duplicate_performance_score. Maybe there is some assumption in mini_sentry that the change fails to address, but I could not find it.

@iker-barriocanal iker-barriocanal merged commit a3f169e into getsentry:master Apr 18, 2024
19 checks passed
@supervacuus supervacuus deleted the feat/support_linux_distribution_in_os_context branch April 18, 2024 10:36
narsaynorath pushed a commit to getsentry/sentry that referenced this pull request May 17, 2024
Users of the Native SDK also want to search for the Linux distributions
their events came from:
getsentry/sentry-native#943

The corresponding PRs to

* develop docs: getsentry/develop#1227
* relay: getsentry/relay#3443
* Native SDK: getsentry/sentry-native#963
cmanallen pushed a commit to getsentry/sentry that referenced this pull request May 21, 2024
Users of the Native SDK also want to search for the Linux distributions
their events came from:
getsentry/sentry-native#943

The corresponding PRs to

* develop docs: getsentry/develop#1227
* relay: getsentry/relay#3443
* Native SDK: getsentry/sentry-native#963
JoshuaMoelans added a commit that referenced this pull request Nov 28, 2024
…4292)

(continuation of #3443 )

<!-- Describe your PR here. -->
To make these fields searchable, we had to change from a nested to a
flattened approach. This is provided in sentry-native ([relevant
PR](getsentry/sentry-native#963)).

The update is also tracked on the docs side:
getsentry/sentry-docs#11936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants