CORS issue with Kirby QL

[sophiamsb]

Description

After Updating Kirby 3.9.7 to Kirby 4.0.0-beta-2 , the request query status responds with error code 401 with message "Unauthenticated".

Expected behavior
The request should be successful and return status code 200 OK

Screenshots
Here is my config.php and .htaccess files to document accessibility. It works fine with Kirby 3.9.7

To reproduce

1. Replace Kirby folder on the server
2. Go to browser and reach the website url
3. Go to dev tools and check console message
   Result : Error message
   " POST https://my-website.com/api/query 403 (forbidden) "

Your setup

Kirby Version
Update from Kirby 3.9.7 to Kirby 4.0.0-beta-2

Your system (please complete the following information)

• Device: Mac Pro
• OS: macOS Monterey
• Browser: Chrome/ Safari / Firefox

Additional context
using Kirby QL and React

[lukasbestle]

I'm confused. Is it "HTTP 401 Unauthenticated" or "HTTP 403 Forbidden"? Also, have you checked if your custom route to respond to OPTIONS requests still works?

(In the future, please post your code in Markdown code blocks like:

```php
$your->code();
```

so we can more easily reproduce the issue without having to manually type the text from the screenshots.)

[sophiamsb]

oh sorry maybe I misunderstood the problem : checking the network activity, the post request is not working: [image: Screenshot 2023-10-24 at 13.28.13.png] [image: Screenshot 2023-10-24 at 13.28.23.png] Le mar. 24 oct. 2023 à 12:47, Lukas Bestle ***@***.***> a écrit :

…

I'm confused. Is it "HTTP 401 Unauthenticated" or "HTTP 403 Forbidden"? Also, have you checked if your custom route to respond to OPTIONS requests still works? — Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJQ5SIXR43VNJVOBFNAXXGTYA6MF3AVCNFSM6AAAAAA6NPS3C6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWHE3TEMZWGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[lukasbestle]

Looks like GitHub didn't know what to do with your attached screenshots. Could you please post them via the GitHub UI?

[sophiamsb]

Sure !

Here are the screenshots:

About the custom route responding to OPTIONS requests , where can I check that ?

[lukasbestle]

The HTTP 403 response can have many reasons. Could you please post the full response including the response body?

Regarding the OPTIONS request: You can test that with the following from the browser console:

await fetch("https://dev.sophiamsaoubi.net/api/query", {method: "OPTIONS"});

Alternatively you can use tools like cURL on the command line or (if you prefer GUI tools) there are also HTTP apps to test the request.

[sophiamsb]

Here is the full response body:

and when I check the OPTIONS request I get this:

But when I do the OPTIONS request with the url of on my current website which works, I get the same output...

[lukasbestle]

From your screenshot it's a bit hard to see what's going on with the OPTIONS request.

But unrelated to that, the issue you are having with KQL (from the first screenshot) is that the current stable version does not yet support Kirby 4. Could you please try if the changes from this PR fix the issue for you? #52

[sophiamsb]

I tried some stuff but still not working... is it the correct fix ?

path: site/plugins/kql/composer.json
change this

"require": {
		"php": ">=8.0.0 <8.3.0",
		"getkirby/cms": ">=3.8.2",
		"getkirby/composer-installer": "^1.2.1"
	},

to this

"require": {
		"php": ">=8.0.0 <8.3.0",
		"getkirby/cms":"^3.9",
		"getkirby/kql": "dev-v4-compat",
		"getkirby/composer-installer": "^1.2.1"
	},

path: site/plugins/kql/src/Kql/interceptors/cms/Content.php
change this

<?php

namespace Kirby\Kql\Interceptors\Cms;

use Kirby\Kql\Interceptor;

class Content extends Interceptor
{

to this

<?php

namespace Kirby\Kql\Interceptors\Cms;

use Kirby\Kql\Interceptors\Content\Content as NewContent;

class Content extends NewContent
{

[lukasbestle]

We've released KQL 2.1.0 today, which officially supports Kirby 4. Could you please try updating to that and check if it works for you?

[sophiamsb]

I upgraded the KQL and it's working ! Thanks for the support :)