[v5] Running page save/update in after hook results in phantom unsaved changes notification

[adamkiss]

Description

If you need to change something in a page automatically - in my case auto-generate title based on other fields - it was always best to do so in a page.update:after hook. In v5-beta.1, the originating update is saved correctly, the hook is run (and change persisted), but the tracking system (sometimes) incorrectly keeps the page marked as changed (or re-marks, maybe?).

Sometimes the yellow buttons popup right away, sometimes after refresh, sometimes they don't pop up at all and page isn't marked changed.

I observe this pretty often (> 80%) when the page is saved with ⌘S, but trigger it slightly less (60%?) while saving by clicking the save button.

Expected behavior

1. Page is saved
2. Hook runs
3. Page isn't marked by system as having changes

Screenshots

CleanShot.2024-12-16.at.22.27.28.mp4

To reproduce

1. Have a bluprint marked with changeTitle: false
2. Add following hook:

[
	'page.update:after' => function (Page $newPage)  {
		kirby()->impersonate('kirby');

		$p->save(['title' => 'Automatically changed title at '.time()]);

		kirby()->impersonate(null);
	}
]

3. Update a page of that blueprint couple of times and observe mayhem.

Note: additionally, I don't remember having to release the kirby impersonate call before, but now it triggers the "other user is editing this page" popup.

Your setup

Kirby Version
v5-beta.1