-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: group nesting/subgroups #4337
Enhancement: group nesting/subgroups #4337
Conversation
I’ll add all those changes you’ve mentioned, and i will say that I added it due to the fact that it’s the most requested non-widget feature in discussions. |
Again, most requested does not always necessarily mean belongs in this project. Sometimes features get up-voted because they've hung around for a while. I see my role as a maintainer as a steward of the project as much as anything else, i.e. to maintain its quality and keep it focused. I worry this is going to get messy... |
I think this feature is something basic enough that it makes sense in the project. If this idea isn't wanted in the project, that's fine, but I do think that something like this would benefit the project. |
In terms of stylistic changes, i'm implementing |
|
…low nesting infinite layers of subgroups
Sorry Im not happy with this PR, I'm going to close it for now and have a think about how to do this, but stuff like this is generally very poor practice: .filter((entry) => entry[Object.keys(entry)[0]].type == "group")
.map((entries) => ({
style: entries[Object.keys(entries)[0]].style,
icon: entries[Object.keys(entries)[0]].icon,
columns: entries[Object.keys(entries)[0]].columns,
header: entries[Object.keys(entries)[0]].header,
...mappingFunc(entries, entries[Object.keys(entries) You are iterating an object, creating arrays repeatedly etc. In general I'd really prefer you try to tackle some smaller PRs, the review requirement here is very high for these things that touch a lot of different parts of the app. Thanks |
Proposed change
Adds Nested groups and subgroups, with the following formatting
Closes #2310
Type of change
Checklist: