Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Add note about copying default rules into config file #96

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

caitlinelfring
Copy link
Member

@caitlinelfring caitlinelfring commented Jul 7, 2021

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Doc update

What is the current behavior? (You can also link to an open issue here)
Confusion around utilizing default rules in a config file. Closes #89

What is the new behavior (if this is a feature change)?
See conversation in issue for more details

Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
No

Other information:

Copy link

@guykisel guykisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much!

@caitlinelfring caitlinelfring merged commit eb3be5b into main Jul 7, 2021
@caitlinelfring caitlinelfring deleted the fix/89 branch July 7, 2021 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default rules set doesn't appear to be valid yaml
2 participants