Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add multiarch support #216

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

sxd
Copy link
Contributor

@sxd sxd commented Jul 15, 2022

Modify .goreleaser.yml file to build two images one for amd64 and
another for arm64 and then create the proper manifest to publish
with the proper images.

Closes #215

Signed-off-by: Jonathan Gonzalez V [email protected]

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features) see docs/README.md

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature

What is the current behavior? (You can also link to an open issue here)
#215

What is the new behavior (if this is a feature change)?
A container manifest with multiarch images inside

Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
No

Other information:

.goreleaser.yml Show resolved Hide resolved
.goreleaser.yml Show resolved Hide resolved
@sxd sxd force-pushed the multiarch_support branch 2 times, most recently from 8cebbf3 to 460c9c9 Compare July 19, 2022 13:07
@sxd sxd force-pushed the multiarch_support branch from 460c9c9 to 093e414 Compare July 19, 2022 13:13
Modify .goreleaser.yml file to build two images one for amd64 and
another for arm64 and then create the proper manifest to publish
with the proper images.

Closes get-woke#215

Signed-off-by: Jonathan Gonzalez V <[email protected]>
@sxd sxd force-pushed the multiarch_support branch from 093e414 to 0c2f5bc Compare July 19, 2022 13:22
@caitlinelfring caitlinelfring merged commit cc4fe39 into get-woke:main Jul 19, 2022
@sxd
Copy link
Contributor Author

sxd commented Jul 19, 2022

@caitlinelfring the GoReleaser team will remove the beta warning now =) just got an answer :D

@caitlinelfring
Copy link
Member

Awesome thanks for following up!

@sxd sxd deleted the multiarch_support branch July 19, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multiarch support to container image
2 participants