Add --disable-default-rules flag
#132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 95.27% 95.84% +0.57%
==========================================
Files 22 22
Lines 740 746 +6
==========================================
+ Hits 705 715 +10
+ Misses 21 19 -2
+ Partials 14 12 -2
Continue to review full report at Codecov.
|
caitlinelfring
force-pushed
the
disable-default-rules-option
branch
from
5197c6d to
fa60209
Compare
woke will error if you run it with `--disable-default-rules` without providing your own rules in a config file (because that would mean you're running woke without any rules, which is pointless)
caitlinelfring
force-pushed
the
disable-default-rules-option
branch
from
fa60209 to
174840f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
The process isn't great if you want to disable the default ruleset entirely and provide your own rules. You have to follow the instructions in https://github.com/get-woke/woke#disabling-default-rules and then add your own.
What is the new behavior (if this is a feature change)?
You can now provide
--disable-default-rulesas a flag which will not run any of the default rules. It will error if you run it with--disable-default-ruleswithout providing your own rules because that would mean running woke without any rules, which is pointlessDoes this PR introduce a breaking change? (What changes might users need to make due to this PR?)
No, this is an additive change only and will not impact users
Other information:
Closes #129