Use null terminator for masking inline ignore #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 20 20
Lines 583 583
=======================================
Hits 561 561
Misses 13 13
Partials 9 9
Continue to review full report at Codecov.
|
caitlinelfring
force-pushed
the
issue/109
branch
from
76b974a to
93b586d
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
Use the
unicode.ReplacementChar� to mask any inline ignores so they don't result in a "finding". This is actually a three byte symbol and causes the matcher to return incorrect and out of bound indexesWhat is the new behavior (if this is a feature change)?
Switch to using a single byte character to mask inline ignores (null terminator - http://en.wikipedia.org/wiki/Null_character). The goal is to use something that wouldn't trigger any findings
Does this PR introduce a breaking change? (What changes might users need to make due to this PR?)
No
Other information:
Fixes #109