-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XASX open time is incorrect #250
Comments
Wouldn't 9:59:45 be rounded to nearest minute = 10:00? I'm curious where you see 9:59. |
if a trade happens at 09:59:45 then it will be in the minute bar "9:59->10:00", with a left label "9:59" |
Hi @j7zAhU, this is a peculiar one, thanks for raising it. I can certainly appreciate the argument that the open could be 09:59 because, as you point out, a relatively small selection of stocks can print a trade during the minute from 09:59 - 10:00, or more precisely from 09:59:45 - 10:00:00. This situation is similar to XTAE (#146), but not the same. XTAE can print a trade any time from 09:59:00, whereas the earliest that a trade can be printed for XASX is 09:59:45, i.e. XASX is never open at 09:59:00 (for regular trading) . Indeed, it's never open before 09:59:45. I think the question becomes 'does that 15 second window warrant a trading minute of its own, with the open set to 09:59, or as @ValueRaider intimated, should it be rolled into the minute from 10:00 - 10:01'. One use case of For the moment at least, I'd favour retaining the open as 10:00 and assuming that trades printed between 09:59:45 to 10.00 are rolled into 10:00 - 10.01. I think there would be more of a case for setting the open to 09:59 if anyone can show there are popular data sources with ' 1 minute' data that includes the 09:59 - 10:00 minute. Aside on XASX opensLooking at how the opening times for XASX actually run from 10:00 through 10:09 (+/- 15 seconds) depending on the equity symbol, strictly there should be five subclasses of XASX to cover each equity group. Aside on
|
Hi @maread99 I discovered this issue doing exactly what you mentioned - indexing against a data query. In this case it is the Bloomberg API. The following is some minutely OHLC output for the stock The timezone is UTC+10. Notice the large volume in minute 9:59. It is indeed the opening print. You can argue that the two most important timestamps of the day are currently not captured. I think they ought to be included. I love the library otherwise. |
What happens if you request larger intervals? Does BB merge those 15 seconds into the interval starting on hour? |
Certainly strengthens the argument for a 09.59 open. On the back of this I'd have no objections to a PR changing the open to 09.59. @j7zAhU, if you're using Also, couple of polite requests...
Cheers |
Thank you for those @j7zAhU.
Any chance of being able to see this same query for RIO at 1min intervals? Thanks! |
The Bloomberg data is certainly not indexed as I would have anticipated. The fact the 15min intervals are anchored on 23:59 even through the first trade doesn't register until 00:06 suggests some knowledge of the underlying exchange, with the exchange assumed to open at 23:59. But in this case, why does the first stamp for the other stock you offered show at 00:00? Not sure what's going on. In any event, as I mentioned, I wouldn't object to the open being 09:59 - please PR if you want to request the change. Thanks for all the info @j7zAhU! |
Glad I could help. I prob won't have the time to submit a PR in the foreseeable future. Thanks for taking the feedback on board |
If you do find yourself needing the change, the PR would be pretty simple, workflow at the bottom of this page. |
Group 1 ASX stocks open at 10am +/- 15 seconds. This means there may be a "left index 9:59" trade time on approximately 50% of trading days.
https://www2.asx.com.au/markets/market-resources/trading-hours-calendar/cash-market-trading-hours
The text was updated successfully, but these errors were encountered: