Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XHKG late opens (black rain half days) #142

Open
limx0 opened this issue Feb 4, 2022 · 4 comments
Open

XHKG late opens (black rain half days) #142

limx0 opened this issue Feb 4, 2022 · 4 comments
Labels
calendar update Calendar needs updating

Comments

@limx0
Copy link

limx0 commented Feb 4, 2022

19 Aug 2020

Hong Kong Exchanges and Clearing Limited (HKEX) announced that trading in the securities and derivatives markets will resume at 1:30pm, following the cancellation of Typhoon Signal No. 8. Stock Connect trading will resume from 1:30pm according to the Rules of the Exchange.

https://www.hkex.com.hk/News/Market-Communications/2020/2008192news?sc_lang=en

@maread99 maread99 changed the title XHKG black rain half day 2020-08-19 XHKG late opens (black rain half days) Feb 4, 2022
@maread99
Copy link
Collaborator

maread99 commented Feb 4, 2022

@limx0, thanks for the info.

By coincidence, yesterday I found the same is true of 28 June 2021. Both 2020-08-19 and 2021-06-28 shoud be declared as late opens.
https://www.hkex.com.hk/News/Market-Communications/2021/2106282news?sc_lang=en
https://www.hkex.com.hk/News/Market-Communications/2021/2106283news?sc_lang=en

All calendars are maintained via contributions. Guide here.

Please PR any changes you want introduced to XHKG.

@limx0
Copy link
Author

limx0 commented Feb 4, 2022

Will do @maread99 - is there an established convention for late opens (I couldn't see one from the existing days in xhkg)?

@maread99 maread99 self-assigned this Feb 4, 2022
@maread99
Copy link
Collaborator

maread99 commented Feb 4, 2022

There is. You should be able to just define the special_opens_adhoc property in XHKGExchangeCalendar. The doc for the property as defined on the base class explains what's expected.

I think I'm right in saying that this would be the first calendar to implement a late open, although plenty of them implement adhoc early closes and the properties are defined in the same manner.

You'll see XHKGExchangeCalendar already defines special_closes_adhoc, although you'd probably be better off checking out the simpler XNYSExchangeCalendar.special_closes_adhoc which is more in line with what you're after.

You might find the PR's not all plain sailing due to the calendar having breaks, although having said that the base implementation works fine with the early closes - recognising that those days don't have a break. In theory, it should do the same with the late opens.

Any issues let me know.

Cheers.

@maread99 maread99 added the calendar update Calendar needs updating label Jun 28, 2022
@maread99 maread99 removed their assignment Sep 13, 2022
@npezolano
Copy link

Seems some of the recent market closures are missing as well,

2023-07-17 for example was a typhoon closure
https://www.hkex.com.hk/News/Market-Communications/2023/2307172news?sc_lang=en

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calendar update Calendar needs updating
Projects
None yet
Development

No branches or pull requests

3 participants