Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_prev_next_minute is needlessly slow #103

Open
maread99 opened this issue Oct 19, 2021 · 0 comments
Open

test_prev_next_minute is needlessly slow #103

maread99 opened this issue Oct 19, 2021 · 0 comments
Labels
good first issue Good for newcomers tests all things tests

Comments

@maread99
Copy link
Collaborator

maread99 commented Oct 19, 2021

Because it blanket tests the edges of all sessions, the test_prev_next_minute is one of the slowest tests of the suite.

The test could be sped up considerably by focusing on the edges of sessions of Answers.session_blocks (as a number of other tests already do).

If anyone wants to get familiar with the test suite, this would be a good PR to take up (maybe start by having a look at the test inputs available from the Answers class and then at how the tests for other similar methods are implemented).

@maread99 maread99 added good first issue Good for newcomers tests all things tests labels Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers tests all things tests
Projects
None yet
Development

No branches or pull requests

1 participant