Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If textSymbolizer opacity equal to 0, xml change to 1 #912

Closed
liqpy opened this issue Jan 9, 2024 · 4 comments · Fixed by #914
Closed

If textSymbolizer opacity equal to 0, xml change to 1 #912

liqpy opened this issue Jan 9, 2024 · 4 comments · Fixed by #914
Assignees
Labels
bug Something isn't working released

Comments

@liqpy
Copy link

liqpy commented Jan 9, 2024

Bug

surce code
[CssParameter]: [{
'#text': textSymbolizer.opacity || '1',
}],
':@': {
'@_name': 'fill-opacity'
}
expectation
The original value was 0.

Thank you for making the change.

@liqpy liqpy added the bug Something isn't working label Jan 9, 2024
@KaiVolland
Copy link
Contributor

KaiVolland commented Jan 9, 2024

Yes this seems to be wrong. Do you want to provide a PR? Otherwise it might need some time until this will be fixed.
Number.isFinite should do the trick.

@liqpy
Copy link
Author

liqpy commented Jan 10, 2024

I don't know if there are similar issues elsewhere, i just made a simple change to this line of code;
line: 1940;
source code:
'#text': textSymbolizer.opacity || '1',
change code:
'#text': Number.isFinite(textSymbolizer.opacity) ? textSymbolizer.opacity : '1',
The output does indeed retain the original value, but more specific inspections are still needed from you, looking forward to you fix it later on.

@KaiVolland
Copy link
Contributor

Fixed with #914

@jansule
Copy link
Contributor

jansule commented Jun 25, 2024

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants