fix invalid supported UOMs description #686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix process description literal UOMs reporting duplicates of the first default UOM instead of all supported UOMs.
For example, passing
uoms=['metre', 'feet']
toLiteralInput
would cause it to report as follows in the WPS description.The default UOM would be repeated for as many supported UOMs that were passed to the input.
At the same time, this fixes the optional
reference
attribute accordingly if it was not provided explicitly, or could not be mapped to a known unit of OGC URN.According to https://schemas.opengis.net/ows/1.1.0/owsDomainType.xsd
the
ows:UOM
which depends onows:DomainMetadataType
shows
<attribute ref="ows:reference" use="optional" />
But the previous check of
UOM
class caused it to check ofOGCUNIT
if not provided with an empty string.The corresponding
if
in the template were also not consistent about reportingreference
.Related Issue / Discussion
Required by crim-ca/weaver#541
Required by crim-ca/weaver#430
Fixes #685
Contribution Agreement
(as per https://github.com/geopython/pywps/blob/master/CONTRIBUTING.rst#contributions-and-licensing)