Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Datahub] [Resdesign] Abstract section #767

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[Datahub] [Resdesign] Abstract section #767

merged 2 commits into from
Jan 22, 2024

Conversation

cmoinier
Copy link
Collaborator

@cmoinier cmoinier commented Jan 15, 2024 •
edited
Loading

This PR applies the redesign of the header section, namely :

  • remove abstract title
  • remove keywords from the section

To test

Dataset /dataset/01491630-78ce-49f3-b479-4b30dabc4c69.

Screenshot

image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2024 •
edited
Loading

Affected libs: ui-elements, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-dataviz, ui-catalog, ui-search,
Affected apps: datahub, metadata-editor, demo, webcomponents, map-viewer, search,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Jan 15, 2024 •
edited
Loading

Coverage Status

coverage: 86.378% (+4.2%) from 82.169%
when pulling d8f14f4 on DH/redesign-abstract
into 9ae0a68 on main.

Angi-Kinas
Angi-Kinas approved these changes Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@cmoinier cmoinier force-pushed the DH/redesign-abstract branch from d433801 to 9c05f94 Compare January 22, 2024 09:26
@cmoinier cmoinier merged commit 55bb5e1 into main Jan 22, 2024
8 checks passed
@cmoinier cmoinier deleted the DH/redesign-abstract branch January 22, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Angi-Kinas Angi-Kinas Angi-Kinas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cmoinier @coveralls @Angi-Kinas