Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor]: Use correct font family and sizes #1029

Merged
merged 7 commits into from
Oct 29, 2024
Merged

Conversation

cmoinier
Copy link
Collaborator

Description

This PR makes sure the editor is using the right font families (Petrona & Inter), and that all texts are of the right sizes, according to the mockups.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

@cmoinier cmoinier force-pushed the ME-use-right-text-size branch from e1a44c1 to e06f2f4 Compare October 25, 2024 14:02
Copy link
Contributor

github-actions bot commented Oct 25, 2024

Affected libs: feature-editor, ui-search, feature-search, feature-router, feature-map, feature-dataviz, feature-record,
Affected apps: metadata-editor, datafeeder, demo, datahub, webcomponents, search, map-viewer,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Contributor

github-actions bot commented Oct 25, 2024

📷 Screenshots are here!

@coveralls
Copy link

coveralls commented Oct 25, 2024

Coverage Status

coverage: 83.168% (-0.7%) from 83.88%
when pulling 6064f3b on ME-use-right-text-size
into 09f416f on main.

Copy link
Collaborator

@Angi-Kinas Angi-Kinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cmoinier and @jahow for adapting the editor to use the correct fonts and and font-sizes across the app! It looks much nicer already.

Two things that came to my eye when checking the app:

  • The font sizes in the dashboard table (except the name of the record) should be 12 px:
    image

  • the font-family for the dashboard menu titles should be "Petrona" and for the "Metadata record" "Inter" (see screenshot):
    image

Copy link
Collaborator

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great, thanks!

@cmoinier cmoinier merged commit 8844112 into main Oct 29, 2024
13 checks passed
@cmoinier cmoinier deleted the ME-use-right-text-size branch October 29, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants