-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor]: Rework action-menu #1024
Conversation
component.duplicateRecord.subscribe((r) => (recordToBeDuplicated = r)) | ||
component.duplicateRecord.subscribe((r) => { | ||
recordToBeDuplicated = r | ||
}) | ||
}) | ||
|
||
it('emits a duplicateRecord event', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was modified because it was more of an e2e test than a UT, which should test functions and not UI elements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense :) although please keep in mind that sometimes unit tests can interact with the DOM too, if there's some logic related to DOM events for instance!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! In this case it seemed to me that it was something that could be done (and is already done, actually), in the e2e. I figured it made more sense to test the related logic without all the clicking on the fixture :)
Affected libs:
|
📷 Screenshots are here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9ba70fb
to
633452d
Compare
Description
This PR reworks the UI of the action-menu in the dashboard.
It now uses the Angular CDK Overlay like in the import button.
Screenshots
Quality Assurance Checklist
breaking change
labelbackport <release branch>
label