From 9209137402513daa170df6a0873b1f2e17eea3e1 Mon Sep 17 00:00:00 2001
From: "david.blasby" <david.blasby@geocat.net>
Date: Wed, 9 Oct 2024 12:46:18 -0700
Subject: [PATCH] doc change + sonar checks for stack traces

---
 gn_checks.xml                                              | 7 ++++++-
 .../fao/geonet/ogcapi/records/service/QueryToElastic.java  | 2 +-
 .../geonet/ogcapi/records/service/QueryablesService.java   | 2 +-
 3 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/gn_checks.xml b/gn_checks.xml
index 25218acf..fe3bdf95 100644
--- a/gn_checks.xml
+++ b/gn_checks.xml
@@ -3,7 +3,12 @@
   "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
   "https://checkstyle.org/dtds/configuration_1_3.dtd">
 
-<!--modified for GN by adding suppression-->
+<!--modified for GN by adding suppression
+    CF https://github.com/checkstyle/checkstyle/issues/11655
+
+    Almost all of this is from
+    https://github.com/checkstyle/checkstyle/blob/checkstyle-8.29/src/main/resources/google_checks.xml
+ -->
 
 
 <!--
diff --git a/modules/services/ogc-api-records/src/main/java/org/fao/geonet/ogcapi/records/service/QueryToElastic.java b/modules/services/ogc-api-records/src/main/java/org/fao/geonet/ogcapi/records/service/QueryToElastic.java
index 661b3e1b..dbd83dc7 100644
--- a/modules/services/ogc-api-records/src/main/java/org/fao/geonet/ogcapi/records/service/QueryToElastic.java
+++ b/modules/services/ogc-api-records/src/main/java/org/fao/geonet/ogcapi/records/service/QueryToElastic.java
@@ -206,7 +206,7 @@ private QueryBuilder createGeo(GnElasticInfo gnElasticInfo, String userSearchTer
           .relation(ShapeRelation.getRelationByName("intersects"));
       return geoQuery;
     } catch (IOException e) {
-      e.printStackTrace();
+      log.debug("problem constructing geoQuery - ignoring it!",e);
     }
     return null;
   }
diff --git a/modules/services/ogc-api-records/src/main/java/org/fao/geonet/ogcapi/records/service/QueryablesService.java b/modules/services/ogc-api-records/src/main/java/org/fao/geonet/ogcapi/records/service/QueryablesService.java
index e1f574a4..00db0ee6 100644
--- a/modules/services/ogc-api-records/src/main/java/org/fao/geonet/ogcapi/records/service/QueryablesService.java
+++ b/modules/services/ogc-api-records/src/main/java/org/fao/geonet/ogcapi/records/service/QueryablesService.java
@@ -40,7 +40,7 @@ public JsonSchema buildQueryables(String collectionId) {
       var result = objectMapper.readValue(text, JsonSchema.class);
       return result;
     } catch (IOException e) {
-      e.printStackTrace();
+      log.debug("problem reading in Queryables - is it mal-formed?",e);
     }
 
     return null;