Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting to Typescript #3

Open
1 of 3 tasks
simenandre opened this issue May 24, 2018 · 5 comments
Open
1 of 3 tasks

Converting to Typescript #3

simenandre opened this issue May 24, 2018 · 5 comments

Comments

@simenandre
Copy link

simenandre commented May 24, 2018

Hello,

I've been porting lambda-proxy-utils to Typescript. I was thinking of writing @types definitions, but this is such a nice little tool I'd rather see it being fully Typescript. As of right now, it has a few lint issues and a broken dependency (i think). There are also 13 @ts-ignore in the classes, those need to be looked at. I've used gts.

  • Rebuild in Typescript
  • Fix linting
  • Fix type-is bug

I got carried away on the Response class, so all options are now written as one variable. We can revert back to the way @geoffdutton has done it. As of yet I have not submitted a pull request, since it's not perfect.

I changed from NPM to Yarn – not really a requirement either, i guess.

Have a look at bjerkio/lambda-proxy-utils.

Cheers!

@geoffdutton
Copy link
Owner

@cobraz I apologize for not paying attention to the Issues section. If you still have interest in this, I'd welcome a PR.

I'm thinking about create v2.0.0 which will drop support for Node 4, but this could also include changing it to typescript.

@hugoduraes
Copy link

@cobraz it'd be great to have the library in Typescript. Are you happy to create a PR as @geoffdutton asked? thanks :)

@simenandre
Copy link
Author

Hello!

I can see what can be done :)

@simenandre
Copy link
Author

I'm picking this up again!

@SimonJang
Copy link

Any update on this? If not, I wouldn't mind taking a look into it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants