Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change image paths from ghcr.io/geocompx/docker:image to ghcr.io/geocompx/image? #88

Open
Robinlovelace opened this issue Oct 7, 2024 · 5 comments · May be fixed by #94
Open

Change image paths from ghcr.io/geocompx/docker:image to ghcr.io/geocompx/image? #88

Robinlovelace opened this issue Oct 7, 2024 · 5 comments · May be fixed by #94
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@Robinlovelace
Copy link
Contributor

See #87
@Robinlovelace Robinlovelace added help wanted Extra attention is needed question Further information is requested labels Oct 7, 2024
@Robinlovelace
Copy link
Contributor Author

What do you think @Nowosad and all? This would be a change for users, who would have to update as follows:

- ghcr.io/geocompx/docker:minimal
+ ghcr.io/geocompx/minimal

Less typing. Should have been like this from this at the start, so this is a bug fix really. Thoughts?

@Nowosad
Copy link
Member

Nowosad commented Oct 7, 2024

👍🏻

@Robinlovelace
Copy link
Contributor Author

Seems to have worked: https://github.com/geocompx/docker/pkgs/container/minimal

@Robinlovelace
Copy link
Contributor Author

Not quite, maybe because there's now latest tag?

PS C:\Users\georl_admin> docker pull ghcr.io/geocompx/minimal
Using default tag: latest
Error response from daemon: manifest unknown
PS C:\Users\georl_admin> docker pull ghcr.io/geocompx/minimal:minimal_f4ef13a
minimal_f4ef13a: Pulling from geocompx/minimal

Robinlovelace added a commit that referenced this issue Oct 7, 2024
@Robinlovelace
Update Dockerfile, trigger minimal pkg build with latest
718c13d 
#88
@Robinlovelace
Copy link
Contributor Author

This now works:

 docker pull ghcr.io/geocompx/minimal

@Robinlovelace Robinlovelace mentioned this issue Oct 7, 2024
Merged
Robinlovelace added a commit that referenced this issue Oct 14, 2024
@Robinlovelace
Change take for minimal example, starter on #88
726c8d8
@Robinlovelace Robinlovelace linked a pull request Oct 14, 2024 that will close this issue
Update tag patterns #94
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update tag patterns geocompx/docker
2 participants
@Robinlovelace @Nowosad