Skip to content
This repository has been archived by the owner on Oct 24, 2024. It is now read-only.

Adding new field broke Document form view #262

Open
karenmajewicz opened this issue Mar 17, 2023 · 5 comments
Open

Adding new field broke Document form view #262

karenmajewicz opened this issue Mar 17, 2023 · 5 comments
Assignees
Labels
attribute-model type:bug Something isn't working

Comments

@karenmajewicz
Copy link
Member

karenmajewicz commented Mar 17, 2023

  1. I added the field to the Elements

  2. I added it to the Form Elements

  3. Going to any Documents page resulted in a "We're sorry, but something went wrong." page.

Attached is a screenshot of the values I filled in for a new field "Display Note". I will adjust these to see if one of them caused the problem.
form

@karenmajewicz karenmajewicz added the type:bug Something isn't working label Mar 17, 2023
@karenmajewicz
Copy link
Member Author

I "Destroyed" the field from the Form Elements page and documents view works again.

@karenmajewicz
Copy link
Member Author

I went back to the Elements and saw that I had the wrong value for Type. I had put in "FormControl". I changed this to 'string'.

On the Dashboard page, the "Admin" button at the top is now non-responsive. I have to reload the page to get it to be clickable again.

ewlarson added a commit that referenced this issue Mar 17, 2023
Try setting caching to false (for now)

Addresses #262
@karenmajewicz
Copy link
Member Author

karenmajewicz commented Mar 17, 2023

After caching was disabled, the new element now appears on the form.

However, it is not showing the correct field Label in the form and shows as Gbl displaynote sm

form2

@ewlarson
Copy link
Contributor

Ah... I forgot about this file that helps drive the Form labels:
https://github.com/geobtaa/geomg/blob/develop/config/locales/documents.en.yml

I'll try and refactor that away.

@ewlarson
Copy link
Contributor

sciencehistory/kithe#162

@ewlarson ewlarson self-assigned this Mar 17, 2023
@ewlarson ewlarson moved this to 🏗 In progress in Q1 2023 Mar 17, 2023
@ewlarson ewlarson moved this from 🏗 In progress to 👀 In review in Q1 2023 Mar 28, 2023
@ewlarson ewlarson moved this from 👀 In review to ✅ Done in Q1 2023 Mar 28, 2023
@karenmajewicz karenmajewicz moved this to 📋 Backlog in Q2 2023 Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
attribute-model type:bug Something isn't working
Projects
No open projects
Status: Done
Status: 📋 Backlog
Status: No status
Development

No branches or pull requests

2 participants