Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nth_unchecked in coordinate lookup should not consult inner dimension #867

Closed
kylebarron opened this issue Nov 15, 2024 · 1 comment
Closed

Comments

@kylebarron
Copy link
Member

kylebarron commented Nov 15, 2024

E.g. for the separated coordinates it should just assume that the nth coordinate buffer is valid and has the given length

(maybe add a debug_assert in there for the length)

@kylebarron
Copy link
Member Author

This is already true, but we should remember to switch to using get_unchecked in the next version of the traits.

@kylebarron kylebarron closed this as not planned Won't fix, can't repro, duplicate, stale Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant