New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write WKB `push_point` without extra copy #857

Open

kylebarron opened this issue Nov 13, 2024 · 0 comments

Member

kylebarron commented Nov 13, 2024

geoarrow-rs/rust/geoarrow/src/array/binary/builder.rs

Lines 84 to 87 in 43a1783

    
           // TODO: figure out how to write directly to the underlying vec without a copy 
        
           let mut buf = Vec::with_capacity(point_wkb_size(geom.dim())); 
        
           write_point(&mut buf, geom, Endianness::LittleEndian).unwrap(); 
        
           self.0.append_value(&buf)

Should be solved by apache/arrow-rs#6652 which adds an std::io::Write impl: https://github.com/apache/arrow-rs/pull/6652/files#diff-ebf17409e5662534f30fbb340e7f95aa95e665eea2799878a264c6f70c633a76R345-R354

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment