-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R]: Export wk reader & writer S3 methods? #69
Comments
Good spot! I haven't had time to circle back to this recently...the main blocker was the geoarrow_array class, as you noted. I'd been planning to call it geoarrow_vctr and have it be basically the same as the geoarrow_vctr here: https://github.com/paleolimbot/geoarrow/blob/master/R/vctr.R . |
Is the intent to bring across the geoarrow_vctr as-is + necessary fixes? Does this package completely replace paleolimbot/geoarrow? |
Yes! I also need to port over
Yes, although I was planning to have it be as minimal as possible and perhaps more aggressively materialize (maybe via arrow for now) when doing anything other than slicing. The minimal useful implementation doesn't really need subsetting at all...just something to exist that somebody can call |
Ok. I'll follow up on the geoarrow_vctr discussion with a separate issue. |
Could we export
wk_handle.geoarrow_array
andwk_writer.geoarrow_array
S3 methods? This will allow for integration with {wk} readers, writers and filters.Geoarrow arrays don't currently have their own class. I'm assuming this is planned?
I think this is all we need (once the geoarrow_array class exists)
The text was updated successfully, but these errors were encountered: