Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User story] Small test data #32

Open
33 of 34 tasks
fellen31 opened this issue Mar 20, 2024 · 3 comments · Fixed by #33
Open
33 of 34 tasks

[User story] Small test data #32

fellen31 opened this issue Mar 20, 2024 · 3 comments · Fixed by #33
Assignees
Labels
Effort L Effort Large enhancement New feature or request Gain L Gain Large needs refinement This issue needs refinement Urgency L Urgency Large

Comments

@fellen31
Copy link
Collaborator

fellen31 commented Mar 20, 2024

Need

As a developer, I need the pipeline to have a test profile with accompanying relevant test data, which should test if not all then at least the majority of the pipeline.

Suggested approach

Currently there are three presets available: pacbio, revio and ONT_R10. Using the revio preset should cover all pacbio cases.

Can be closed when

  • Tested with BAM input
    •  Revio
    •  ONT
  •  Tested with fastq input
    •  Revio
    •  ONT
  • Tested with default parameters
    •  Revio
    •  ONT
  • Tested with one sample
    •  Revio
    •  ONT
  • Tested with multiple samples
    •  Revio
    •  ONT
  • Tested with multiple files per sample
    •  Revio
    •  ONT
  • Tested with --split_fastq > 1 
    •  Revio
    •  ONT
  •  Tested with --parallel_snv 1
    •  Revio
    •  ONT
  • Tested with samples where sex=0
    •  Revio
    •  ONT
      • Update somalier to v0.2.19 to prevent infer sex bug
  • Tested with BED
    •  Revio
    •  ONT
  • Tested without BED
    •  Revio
  • Replace multisample test data with NIST trio #478

Additional considerations

HIPHASE_SV takes input from both DeepVariant and an SV caller to phase reads. Sniffles is not supported and it will fail depending on how the calls in the VCF looks. Ideally the test data would maybe provide all possible types of SVs, because with the current test data HiPhase will not fail (or remove HiPhase, or add psbv as input which is the only supported SV-caller).

@fellen31 fellen31 added the enhancement New feature or request label Mar 20, 2024
@fellen31 fellen31 self-assigned this Mar 20, 2024
@fellen31 fellen31 added this to the Basic functionality milestone Mar 22, 2024
@fellen31 fellen31 mentioned this issue Mar 22, 2024
10 tasks
@fellen31
Copy link
Collaborator Author

fellen31 commented Mar 22, 2024

Added working revio test data in #33. Points above still valid.

If possible, the test data should also be able to:

  • Assemble both haplotypes

@fellen31 fellen31 reopened this Mar 22, 2024
@fellen31 fellen31 changed the title Add test profile Add small test data Mar 22, 2024
@fellen31
Copy link
Collaborator Author

fellen31 commented Apr 4, 2024

Adding CNV-workflow as separate issue (#60)

@fellen31
Copy link
Collaborator Author

Add SNV-annotation to test profile as separate issue (#74)

@fellen31 fellen31 removed this from the Basic functionality milestone Apr 16, 2024
@fellen31 fellen31 added this to Nallo May 3, 2024
@fellen31 fellen31 added the needs refinement This issue needs refinement label May 29, 2024
@fellen31 fellen31 changed the title Add small test data [User story] Small test data Jun 13, 2024
@fellen31 fellen31 added Gain L Gain Large Effort L Effort Large Urgency L Urgency Large labels Jun 16, 2024
@fellen31 fellen31 mentioned this issue Jun 28, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort L Effort Large enhancement New feature or request Gain L Gain Large needs refinement This issue needs refinement Urgency L Urgency Large
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant