Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test all the methods on all the operating systems #247

Merged
merged 18 commits into from
Jan 20, 2021
Merged

Conversation

gelisam
Copy link
Owner

@gelisam gelisam commented Jan 6, 2021

Fixes #245. Hopefully. But realistically not; these things always take several attempts.

@gelisam
Copy link
Owner Author

gelisam commented Jan 6, 2021

$ cabal v2-install
Symlinking 'hawk.exe'
cabal.exe: Symlinking feature not available on Windows

...then why is cabal making a symlink instead of a copy?

@gelisam
Copy link
Owner Author

gelisam commented Jan 6, 2021

According to the documentation, cabal should already use copy instead of symlink on Windows. This has been merged in February 2020. We're now in January 2021. Surely that code has been released since?

@gelisam
Copy link
Owner Author

gelisam commented Jan 6, 2021

Nope; even though cabal 3.2.0.0 (which github actions is using) was released in April 2020, it doesn't look like that patch made it in. So I'll just have to manually specify --install-method=copy on Windows.

@gelisam
Copy link
Owner Author

gelisam commented Jan 18, 2021

Okay, now that I've finally figured out the right PowerShell syntax, I see that the installation-method detection code doesn't work on Windows. Hawk used to work on Windows, but it's clear that it's now broken. I don't think it would be too hard to make Hawk work on Windows, but with #239 and now this, it's starting to become a sizeable chunk of work.

Since there are so many other things to fix in this codebase, I think it would be better to cut my losses now: I am dropping support for Windows (until I get feedback from users saying they want it). See #248.

currently, hawk builds and installs fine on Windows, and then
disappointingly fails at runtime. better tell the user in advance that
it isn't going to work.
I was previously using "stack build" in both the "oldest" and "stable"
configurations. I now want "stack install" so I can confirm that running
the stack executable from the command-line works, but I forgot to change
one of the two "stack build"s to "stack install".
@gelisam gelisam merged commit 18a14d6 into main Jan 20, 2021
@gelisam gelisam deleted the issue-245/matrix-test branch January 20, 2021 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test with all OS / installation method combinations
1 participant