Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent a large models list payload from crashing the session #54

Closed
parseccentric opened this issue Feb 26, 2021 · 2 comments
Closed

Prevent a large models list payload from crashing the session #54

parseccentric opened this issue Feb 26, 2021 · 2 comments
Assignees
@parseccentric

Comments

@parseccentric
Copy link
Contributor

Prevent "memory access out of bounds" error. Do this by blocking large models from loading if they will go over a specified memory limit.

Started 2/17/21.

Related: #26
@parseccentric parseccentric self-assigned this Feb 26, 2021
@parseccentric
Copy link
Contributor Author

Estimated time on this issue so far: 40h completed.

@parseccentric
Copy link
Contributor Author

Significant progress has been made in #62 with WebGLMemoryStats and related classes. However, these checks do not successfully block some loading function from crashing the Oculus browser on Quest.

In the meantime, we have changed our officially supported browser to Firefox Reality (Quest) and Firefox Reality (Viveport), because they handle memory growth beyond 256mb.

We will update this issue when we make progress on it, and if the Oculus browser / Android Chromium's memory growth improve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parseccentric parseccentric

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@parseccentric