Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of tx.origin in ERC20Manager #193

Open
mertwole opened this issue Nov 1, 2024 · 0 comments · May be fixed by #219
Open

Get rid of tx.origin in ERC20Manager #193

mertwole opened this issue Nov 1, 2024 · 0 comments · May be fixed by #219
Assignees
@mertwole
Labels
breaking ethereum-contracts stability

Comments

@mertwole
Copy link
Member

mertwole commented Nov 1, 2024

#179 (comment)

It can be achieved by passing sender as parameter to requestBridging or by transferring funds to BridgingPayment address first
@mertwole mertwole changed the title Replace tx.origin with msg.sender in ERC20Treasury and ERC20Gateway Get rid of tx.origin in ERC20Treasury and ERC20Gateway Nov 1, 2024
@mertwole mertwole mentioned this issue Nov 1, 2024
Merged
@mertwole mertwole changed the title Get rid of tx.origin in ERC20Treasury and ERC20Gateway Get rid of tx.origin in ERC20Manager Nov 25, 2024
@mertwole mertwole self-assigned this Nov 28, 2024
@mertwole mertwole linked a pull request Nov 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertwole mertwole

Labels
breaking ethereum-contracts stability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(erc20-manager): Replace tx.origin with msg.sender gear-tech/gear-bridges
1 participant
@mertwole