Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .editorconfig so github uses the correct tab size (4) #1381

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

techee
Copy link
Member

@techee techee commented Nov 2, 2024

See the related discussion in geany/geany#1193.

The branch with this commit is here

https://github.com/techee/geany-plugins/tree/editorconfig

so the effect of this PR can be examined by browsing the code there.

@techee
Copy link
Member Author

techee commented Nov 2, 2024

Not really sure why the unit test fails but seems to be unrelated to the patch.

@eht16
Copy link
Member

eht16 commented Nov 3, 2024

LGTM

@eht16
Copy link
Member

eht16 commented Nov 3, 2024

Not really sure why the unit test fails but seems to be unrelated to the patch.

New cppcheck-version-fun again.
#1382 tries to fix it. For some reason, new cppcheck versions error out on the name "true" when used as a function.
Luckily, this function doesn't seem to be used at all, so removing it was an easy solution.

@techee techee merged commit 63750a5 into geany:master Nov 3, 2024
1 of 2 checks passed
@b4n b4n added this to the 2.1.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants