payara5 hard-coded in ec2-create-instance.sh (rsync logs)

[pdurbin]

At https://jenkins.dataverse.org/job/IQSS-Dataverse-Payara6/8/consoleFull I'm seeing this:

rsync: change_dir "/usr/local/payara5/glassfish/domains/domain1/logs" failed: No such file or directory (2)

I believe the problem is that payara5 hard-coded here:

https://github.com/GlobalDataverseCommunityConsortium/dataverse-ansible/blob/f02346bf4b111c00802d86ac562a0943937307ec/ec2/ec2-create-instance.sh#L258

(rsync -av -e "ssh -i $PEM_FILE" --ignore-missing-args $AWS_USER@$PUBLIC_DNS:/usr/local/payara5/glassfish/domains/domain1/logs/server* $LOCAL_LOG_PATH/)

It looks like payara5 is also hard-coded a little bit down here:

https://github.com/GlobalDataverseCommunityConsortium/dataverse-ansible/blob/f02346bf4b111c00802d86ac562a0943937307ec/ec2/ec2-create-instance.sh#L267

(rsync -av -e "ssh -i $PEM_FILE" --ignore-missing-args $AWS_USER@$PUBLIC_DNS:/usr/local/payara5/glassfish/domains/domain1/logs/server.log* $LOCAL_LOG_PATH/)

Two things:

• Should we introduce an argument so we can pass payara6?
• If we keep server* we probably don't need server.log*, right?

For context, I'm working on IQSS/dataverse#8774 and and once we merge it we'll want the rsync commands to work. For now maybe in the IQSS-Dataverse-Payara6 Jenkins job we can change curl -O https://raw.githubusercontent.com/GlobalDataverseCommunityConsortium/dataverse-ansible/develop/ec2/ec2-create-instance.sh from develop to a new branch we create with payara6 instead of payara5? Whatever makes sense.